Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quickstart.yml #5

Merged
merged 2 commits into from
Aug 27, 2024
Merged

add quickstart.yml #5

merged 2 commits into from
Aug 27, 2024

Conversation

fivetran-jamie
Copy link
Contributor

Similar to all other quickstart.yml files except for the addition of a table_key attribute.

table_key: aws_cloud_cost_report_identifier

Copy link

@fivetran-milanpavlov fivetran-milanpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding quickstart.yml. Feel free to merge

@@ -0,0 +1,11 @@
database_key: aws_cloud_cost_database
schema_key: aws_cloud_cost_schema
table_key: aws_cloud_cost_report_identifier

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this attribute and stick to our default structure because we are not implementing a generic solution to support this for all packages.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that note @fivetran-milanpavlov just removed in latest commit.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit df4cfa7 into main Aug 27, 2024
7 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the add-quickstart branch August 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants