This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
forked from vomatec/cordova-plugin-dgram
-
Notifications
You must be signed in to change notification settings - Fork 1
[INSTORE-424] A small refactoring #4
Merged
darran-kelinske-fivestars
merged 13 commits into
master
from
instore-424-nested-classes
Oct 11, 2019
Merged
[INSTORE-424] A small refactoring #4
darran-kelinske-fivestars
merged 13 commits into
master
from
instore-424-nested-classes
Oct 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdea5e5
to
abd1765
Compare
darran-kelinske-fivestars
suggested changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work gareth - a couple of comments - thank you!
darran-kelinske-fivestars
approved these changes
Oct 11, 2019
darran-kelinske-fivestars
added a commit
that referenced
this pull request
Oct 11, 2019
This reverts commit 9205e4a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTORE-424