Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

[INSTORE-424] A small refactoring #4

Merged
merged 13 commits into from
Oct 11, 2019

Conversation

gareth-ivatt-fivestars
Copy link

INSTORE-424

  1. Break out nested classes DatagramSocketListener and DatagramSocketSend into separate files
  2. Use emit prefix for helper functions that callback to Javascript

@darran-kelinske-fivestars darran-kelinske-fivestars force-pushed the instore-424-nested-classes branch 2 times, most recently from fdea5e5 to abd1765 Compare October 11, 2019 15:18
Copy link

@darran-kelinske-fivestars darran-kelinske-fivestars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work gareth - a couple of comments - thank you!

@darran-kelinske-fivestars darran-kelinske-fivestars merged commit 9205e4a into master Oct 11, 2019
darran-kelinske-fivestars added a commit that referenced this pull request Oct 11, 2019
@darran-kelinske-fivestars darran-kelinske-fivestars deleted the instore-424-nested-classes branch October 11, 2019 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants