Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow DOMProcessingInstruction in Readability and NodeUtility #36

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

blizzz
Copy link

@blizzz blizzz commented Jan 10, 2025

Naive potential fix for #35

With the changes the puny script runs throughs and exits with 0.

I don't know whether this has any other implications, it's just the first time looking into this repo. But maybe it would be simpler to have the allowed node elements implementing an interface.

@fivefilters for your evaluation

@fivefilters fivefilters merged commit f131fcb into fivefilters:master Jan 13, 2025
1 check passed
@fivefilters
Copy link
Owner

Thanks @blizzz!

Looking to see if we can simplify some of the code here with the new released planned for PHP 8.4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants