This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
[RTC-228] Don't send new_tracks notification with empty list #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending
{:new_tracks, []}
was causing EndpointBin in the webrtc plugin thinking it should send offerData.See https://github.com/jellyfish-dev/membrane_webrtc_plugin/blob/master/lib/membrane_webrtc_plugin/endpoint_bin.ex#L689
offerData triggers client SDK to send SDP offer and the whole process of establishing the connection starts.
Because there are no tracks in the SDP, ICE fails (we probably generate wrong SDP) and the whole process is repeated.
The initial idea was not to send offerData when there are no tracks on the server side so I fixed it.