Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Fix/segment duration module #268

Merged
merged 15 commits into from
May 26, 2023
Merged

Fix/segment duration module #268

merged 15 commits into from
May 26, 2023

Conversation

blazpie
Copy link
Contributor

@blazpie blazpie commented May 11, 2023

No description provided.

@blazpie blazpie requested a review from Karolk99 as a code owner May 11, 2023 11:52
@blazpie blazpie requested a review from mickel8 as a code owner May 23, 2023 11:40
Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @Karolk99 gives approve, you can merge

@blazpie blazpie force-pushed the fix/segment_duration_module branch from 06d1a6e to ac4fb1c Compare May 23, 2023 12:29
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #268 (0b26c69) into master (ab0f451) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   62.58%   62.20%   -0.39%     
==========================================
  Files          43       43              
  Lines        2093     2093              
==========================================
- Hits         1310     1302       -8     
- Misses        783      791       +8     
Impacted Files Coverage Δ
...rtc_engine/endpoints/hls/config/sink_bin_config.ex 100.00% <ø> (ø)
lib/membrane_rtc_engine/endpoints/hls_endpoint.ex 76.82% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0f451...0b26c69. Read the comment docs.

@blazpie blazpie force-pushed the fix/segment_duration_module branch from f8fdfcb to 667791b Compare May 23, 2023 18:58
@blazpie blazpie requested a review from sgfn as a code owner May 24, 2023 09:01
Copy link
Contributor

@Karolk99 Karolk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the multiple-track-h264-acc, the video is too short. I checked if, on the master branch, there is the same problem but the video is ok there.

Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blazpie blazpie requested a review from Karolk99 May 24, 2023 12:56
@mickel8
Copy link
Contributor

mickel8 commented May 26, 2023

Please squash commits when merging

@mickel8 mickel8 self-requested a review May 26, 2023 09:14
mix.exs Outdated
@@ -1,14 +1,14 @@
defmodule Membrane.RTC.Engine.MixProject do
use Mix.Project

@version "0.13.0"
@version "0.14.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be as it was

@blazpie blazpie merged commit 640cb15 into master May 26, 2023
@blazpie blazpie deleted the fix/segment_duration_module branch May 26, 2023 09:32
sgfn pushed a commit that referenced this pull request May 29, 2023
sgfn added a commit that referenced this pull request May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants