This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
[RTC-145] Add RTSP Endpoint #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 57.73% 60.46% +2.72%
==========================================
Files 40 43 +3
Lines 1791 2031 +240
==========================================
+ Hits 1034 1228 +194
- Misses 757 803 +46
Continue to review full report in Codecov by Sentry.
|
mickel8
suggested changes
Mar 31, 2023
Comment on lines
+97
to
99
| * `#{inspect(__MODULE__)}.Endpoint.RTSP` which is responsible for connecting to a remote RTSP stream source and | ||
| sending the appropriate media track to other Endpoints. RTSP Endpoint is a Standalone Endpoint. | ||
|
|
There was a problem hiding this comment.
Nice that you updated this description 👍
| @@ -0,0 +1,133 @@ | |||
| defmodule Membrane.RTC.RTSPEndpointTest do | |||
* Copy ConnectionManager over from RTSP to HLS demo * First iteration of RTSP endpoint * lint * attempt fix tests * Fixes after review * More fixes * Fix call to get_required_deps when endpoint module not defined * Fix crash on unrecognised RTP mapping * Bump membrane_rtsp to 0.3.1 * RTSP.PortAllocator first iteration * Remove PortAllocator, add reconnects, tests, fix things * Fixes after review * Fix plugin version in docs * Make FakeRTSPserver more sophisticated * lint * minor fix
sgfn
force-pushed
the
sgfn/RTC-145-rtsp-endpoint
branch
from
74a4d33 to
afbd645
Compare
mickel8
approved these changes
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.