This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Release/v0.11.0 #253
Merged
Release/v0.11.0 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Mar 8, 2023
|
Acctually, could we wait for solving this at first fishjam-dev/membrane_webrtc_plugin#107 |
mickel8
force-pushed
the
release/v0.11.0
branch
from
bf6b544 to
b6eaca4
Compare
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 57.77% 57.82% +0.05%
==========================================
Files 38 38
Lines 1788 1788
==========================================
+ Hits 1033 1034 +1
+ Misses 755 754 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
release/v0.11.0
branch
from
b6eaca4 to
20d5911
Compare
mix.exs
Outdated
| @@ -60,23 +60,23 @@ defmodule Membrane.RTC.Engine.MixProject do | |||
| defp deps do | |||
| [ | |||
| {:membrane_core, "~> 0.11.2"}, | |||
| {:membrane_webrtc_plugin, "~> 0.12.0"}, | |||
| {:membrane_webrtc_plugin, "~> 0.13.0"}, | |||
There was a problem hiding this comment.
Looks like we've got a webrtc / rtp incompatibility here that causes integration tests to fail completely. The same will, I assume, completely break the videoroom.
So, we either:
- revert this change, or
- wait for [RTC-93] Add some RTP metrics membraneframework/membrane_rtp_plugin#142 to be merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.