Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Respawn Stamp Boots when a player was killed #993

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: Respawn Stamp Boots when a player was killed #993

merged 2 commits into from
May 16, 2024

Conversation

Breadp4ck
Copy link
Contributor

@Breadp4ck Breadp4ck commented May 15, 2024 •
edited
Loading

This PR closes #929.

I made WornStompBoots component that marks the entity that created when the player used the boots. When the player is killed (PlayerKilled) and a related entity with WornStompBoots exists (stomp_boots in WearingStompBoots), I respawn the entity with StompBoots component and remove marker WornStompBoots.

@Breadp4ck Breadp4ck changed the title Respawn Stamp Boots when a player was killed feat: Respawn Stamp Boots when a player was killed May 15, 2024
@Breadp4ck Breadp4ck changed the title feat: Respawn Stamp Boots when a player was killed feat: Respawn Stamp Boots when a player was killed (#929) May 15, 2024
@Breadp4ck Breadp4ck changed the title feat: Respawn Stamp Boots when a player was killed (#929) feat: Respawn Stamp Boots when a player was killed May 15, 2024
MaxCWhitehead
MaxCWhitehead requested changes May 16, 2024
View reviewed changes
src/core/elements/stomp_boots.rs Outdated Show resolved Hide resolved
@MaxCWhitehead MaxCWhitehead added this pull request to the merge queue May 16, 2024
@Breadp4ck
Copy link
Contributor Author

@MaxCWhitehead

I think we should not close the issue right now.

However, after experimenting for a while, I discovered that players can equip two boot items, but only one of them will respawn when the player is killed. I suggest dropping the worn boots when a player attempts to equip another pair.

Merged via the queue into fishfolk:main with commit d27a8b7 May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxCWhitehead MaxCWhitehead MaxCWhitehead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spike Shoes are still in player's hand after equipping
2 participants
@Breadp4ck @MaxCWhitehead