fix(networking): Specify local input delay and max prediction window from metadata #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged the bones PR, so you can update this, and feel free to merge once it's update.👍️ |
|
lol apparently cfg! is not compile time or something - have to fix wasm build, gotta run but will fix + merge later. |
|
Weird, |
I think this does happen, and the branch with networking module would probably be optimized out - but I guess because the code is still included it gives an error. Have to use the attribute I guess. |
MaxCWhitehead
added a commit
to MaxCWhitehead/jumpy
that referenced
this pull request
Mar 24, 2024
…from metadata (fishfolk#935) I opened a PR in bones to expose these settings for networking, instead of hard coding in engine. (fishfolk/bones#354) The defaults of these values were also changed in bones such that things are feeling much better in network play with ping around 100ms-150ms. Now we may tune in metadata, though settings only take effect if new network match is created. This will not pass CI until bones PR is merged + bones version updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened a PR in bones to expose these settings for networking, instead of hard coding in engine. (fishfolk/bones#354)
The defaults of these values were also changed in bones such that things are feeling much better in network play with ping around 100ms-150ms.
Now we may tune in metadata, though settings only take effect if new network match is created. This will not pass CI until bones PR is merged + bones version updated.
I think retuning this is a quick and big improvement for high-latency network play. I have WIP for visually smoothing corrections - but I think addressing core issues with networking and getting it as good as possible is priority vs trying to improve how corrections look. Will get that shipped at some point, but want to do some playtesting with more people than myself with various net conditions before spending any more time on net corrections, as it's hard to get right.