Missing props for pointsMaterial

[khiner]

When trying to create a textured point, I get the following errors:

Warning: Foreign prop map found in pointsMaterial
Warning: Foreign prop blending found in pointsMaterial.
Warning: Foreign prop depthTest found in pointsMaterial.

preventing me from using a texture on a point.

My usage:

  this.circleSprite = new THREE.TextureLoader().load(require('../textures/sprites/circle.png'));
  ...

  render() {
    return (<points>
      ...
      <pointsMaterial
        color={0x888888}
        size={50}
        map={this.circleSprite}
        blending={THREE.AdditiveBlending}
        depthTest={false}
        transparent={true}
      />

It looks like PointsMaterialDescriptor is indeed missing all of these possible attributes, although Three does have them as options

[toxicFork]

Thanks for the report, I will be fixing these.

…

On Sat, 31 Dec 2016, 04:38 Karl Hiner, ***@***.***> wrote: When trying to create a textured point, I get the following errors: Warning: Foreign prop map found in pointsMaterial Warning: Foreign prop blending found in pointsMaterial. Warning: Foreign prop depthTest found in pointsMaterial. preventing me from using a texture on a point. My usage: this.circleSprite = new THREE.TextureLoader().load(require('../textures/sprites/circle.png')); ... render() { return (<points> ... <pointsMaterial color={0x888888} size={50} map={this.circleSprite} blending={THREE.AdditiveBlending} depthTest={false} transparent={true} /> It looks like PointsMaterialDescriptor <https://github.com/toxicFork/react-three-renderer/blob/master/src/lib/descriptors/Material/PointsMaterialDescriptor.js> is indeed missing all of these possible attributes, although Three does have them as options <https://github.com/mrdoob/three.js/blob/dev/src/materials/PointsMaterial.js> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#138>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0iLQCtP4BvSdj-gCVn3x21kDVFqdo7ks5rNcAfgaJpZM4LYeTg> .

[khiner]

Thanks for getting on this so quickly! I tried to take it on myself but ran into weird issues locally after doing an npm link to my copy, where it was saying things along the lines of Invalid prop: ...Material expected blah to be of type Vertex but found type Vertex and others like that. Like its comparison between object types would fail if it found my local reference to THREE.Blah when it expected a different THREE.blah.

Anyway, thanks again :)

[toxicFork]

Hmm that happens if there are different versions of THREE present in both projects, it can happen with links if there are separate installations, I may need to add that into the notes for using link Another way is to npm install the directory path of react three renderer

…

On Fri, 6 Jan 2017, 20:11 Karl Hiner, ***@***.***> wrote: Thanks for getting on this so quickly! I tried to take it on myself but ran into weird issues locally after doing an npm link to my copy, where it was saying things along the lines of Invalid prop: ...Material expected blah to be of type Vertex but found type Vertex and others like that. Like its comparison between object types would fail if it found my local reference to THREE.Blah when it expected a different THREE.blah. Anyway, thanks again :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#138 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0iLe4W26DOifx0w6kQYmyY17i_yRQIks5rPoPqgaJpZM4LYeTg> .

[khiner]

Ah, that's exactly what I assumed was happening, couldn't think of another way the class comparison would fail. Good tip on npm install-ing the directory path.