Fix: DeliveryDate missing from request #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShippingDate isn't a parameter, according to PostNL's Documentation: - https://developer.postnl.nl/docs/#/http/api-endpoints/checkout-delivery-options/deliverydate/calculate-shipping-date DeliveryDate parameter only accepts dd-mm-yyyy format, which is the following pattern: - ^[0-3]\d-[0-1]\d-[1-2]\d{3}$ So I formatted the DateTimeInterface (returned by the getDeliveryDate method) to oblidge by that format.
firstred
approved these changes
Sep 18, 2024
|
Thanks so much for the fix! I'll make a new release asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #99
According to PostNL's Documentation,
ShippingDateisn't a valid parameter for the request. Instead, the documentation says to useDeliveryDate.The
DeliveryDateparameter only accepts a value following the DD-MM-YYYY format, which is the following pattern:To follow this pattern, and because you can't pass a DateTimeInterface type in the request, I formatted the return value (from the
getDeliveryDatemethod) to follow the DD-MM-YYYY pattern.