Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libraries + fix some build bugs #282

Merged
merged 6 commits into from
Jul 22, 2023

Conversation

uomar8
Copy link
Contributor

@uomar8 uomar8 commented May 12, 2023

still theres warning in Task :main:compileDevDebugKotlin

@firemaples
Copy link
Owner

firemaples commented May 13, 2023

Thanks for updating the dependencies.
I have a question, have you tried this app on Android 13? 🤔

@uomar8
Copy link
Contributor Author

uomar8 commented May 13, 2023

Thanks for updating the dependencies. I have a question, have you tried this app on Android 13? 🤔

No I only tried on my phone, if you could check that would be great and if there's problem we could work on that

@uomar8
Copy link
Contributor Author

uomar8 commented May 14, 2023

Thanks for updating the dependencies. I have a question, have you tried this app on Android 13? thinking

Just tested on Android studio emulator
Pixel 5 API 33

Most of the time it won't take screenshots correctly it will show black screen
IMG_20230514_100213

Only 2 times out of 14 worked and took screenshot
IMG_20230514_104413

Logcat didn't show any error or any warning 🤔

Edit:
Same with version 3.1.15

@uomar8
Copy link
Contributor Author

uomar8 commented May 14, 2023

Android 14 works great

@firemaples
Copy link
Owner

Sorry for not replying for a long time 🙇‍♂️. Thank you for the tests.
My phone is still Android 12, let me also test it on an emulator and check what happened.

@uomar8
Copy link
Contributor Author

uomar8 commented May 26, 2023

Sorry for not replying for a long time bowing_man. Thank you for the tests. My phone is still Android 12, let me also test it on an emulator and check what happened.

That's okay take your time 👍

@firemaples firemaples force-pushed the update-libraries-+-fix-build-bug branch from de46bfa to 317d21f Compare July 18, 2023 13:52
@firemaples firemaples force-pushed the update-libraries-+-fix-build-bug branch from dda8a4b to a4d6851 Compare July 22, 2023 11:01
@firemaples
Copy link
Owner

Sorry for reply so late, I'll test it a day

Thanks for updating the dependencies. I have a question, have you tried this app on Android 13? thinking

Just tested on Android studio emulator Pixel 5 API 33

Most of the time it won't take screenshots correctly it will show black screen IMG_20230514_100213

Only 2 times out of 14 worked and took screenshot IMG_20230514_104413

Logcat didn't show any error or any warning 🤔

Edit: Same with version 3.1.15

It also happens sometimes on my side, but I don't have an Android 13 real device right now.
Anyway, I'll push this version to beta channel first to check it works well or not.
Thank you for your help 🙇‍♂️

@firemaples firemaples self-assigned this Jul 22, 2023
@firemaples firemaples merged commit a6298a4 into firemaples:master Jul 22, 2023
@uomar8 uomar8 deleted the update-libraries-+-fix-build-bug branch November 24, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants