Magento 2.2+ does not allow update Element here #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can someone please merge it ?@Schrank |
|
Unfortunately I have no clue about this, therefore no - sorry. |
|
Tested on 2.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR - thank you!
Issue
This PR fixes issue #92 .
General
Magento version: 2.2.1
Issue description
When upgrading to Magento 2.2 the layout.xml checking is improved and throws errors when xml-files are not correctly formatted. The problem persists in File catalogsearch_result_index.xml because update Node is inside of body Node.
Steps to reproduce
Install Magento 2.2 or Update from earlier Version
Install FireGento MageSetup2
Perform Search