-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inverting the call tree fast, by computing inverted call nodes lazily #4900
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
db716a5
Add CallNodeInfoInverted.
mstange 68bbf6b
Implement the "suffix order".
mstange 2a3c888
Use the suffix order in getMatchingAncestorStackForInvertedCallNode.
mstange f5e3ad1
Implement getSamplesSelectedStates for inverted trees with the suffix…
mstange 3ac08b9
Use suffix order in getTimingsForCallNodeIndex.
mstange 9f1c8f3
Implement getTreeOrderComparator for the inverted tree with non-inver…
mstange cb7a9ce
Use SampleIndexToNonInvertedCallNodeIndex for the stack chart.
mstange 2259f60
Remove now-unused stack-to-inverted-call-node mapping.
mstange 166342c
Call getNonInvertedCallNodeTable() in more stack-chart-related places.
mstange f2a32cf
Compute inverted call tree timings differently.
mstange 724ed13
Rename leaf to self in many places.
mstange 2da3e88
Use the non-inverted call node table to check for recursion.
mstange 3fc5886
Replace all remaining callers of getCallNodeTable() with xyzForNode()…
mstange 1e9c8ba
Remove now-unused getCallNodeTable().
mstange a0db0ec
Create inverted call nodes lazily.
mstange e44ec8f
Optimize handling of roots.
mstange a891ee2
Make sourceFramesInlinedIntoSymbol an Int32Array.
mstange b25d6b5
Refine the suffix order incrementally, as new inverted nodes are crea…
mstange 9440725
Fold the CallNodeInfoInverted interface into the implementation class.
mstange e1a726b
Remove unused methods from CallNodeInfoNonInverted.
mstange 0cd70fa
Add a test for focus-category on an inverted call tree.
mstange f942782
Merge fast-invert4 with main.
mstange b8a472d
Be more explicit about the expectation that, if we have traced timing…
mstange 3462954
Expand comment about inverted call node indexes (mention that the ord…
mstange 9ddbf1c
Adjust CallNodeInfoInverted documentation based on julien's feedback.
mstange 3c79aff
Clarify that the CallNodePaths used with CallNodeInfoInverted are inv…
mstange e5f0b4c
Rename _findDeepestKnownAncestor to _findDeepestExistingInvertedAnces…
mstange 9252918
Improve comments in getCallNodeIndexFromPath.
mstange 034244c
Move _getChildWithFunc and improve its comments.
mstange 0331c6b
Adjust the comment above _createNonRootNode as requested by julien.
mstange 3f4e927
Clarify the comment about ordering the inverted children by func.
mstange c80f34a
Fix parentDoopNode typo.
mstange File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self, this change could have been in the previous commit (use the non inverted table for the recursive function transform)