feat(blockstore): para shred pool / map and slice (entry batch) exec #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
5 times, most recently
from
d7fa911 to
ac06302
Compare
emwang-jump
reviewed
Jan 31, 2025
src/flamenco/runtime/fd_acc_mgr.c
Outdated
| @@ -204,6 +204,7 @@ fd_acc_mgr_modify_raw( fd_acc_mgr_t * acc_mgr, | |||
| fd_int_store_if( !!opt_err, opt_err, FD_ACC_MGR_ERR_UNKNOWN_ACCOUNT ); | |||
| return NULL; | |||
| } | |||
| __asm__("int $3"); | |||
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
9 times, most recently
from
c1fd55e to
c77a4a4
Compare
emwang-jump
reviewed
Feb 3, 2025
| @@ -585,12 +586,13 @@ unprivileged_init( fd_topo_t * topo, | |||
| strcmp( topo->links[ tile->out_link_id[ REPLAY_OUT_IDX ] ].name, "store_replay" ) || | |||
| strcmp( topo->links[ tile->out_link_id[ REPAIR_OUT_IDX ] ].name, "store_repair" ) ) ) | |||
| FD_LOG_ERR(( "store tile has none or unexpected output links %lu %s", | |||
| tile->out_cnt, topo->links[ tile->out_link_id[ 0 ] ].name )); | |||
| tile->out_cnt, topo->links[ tile->out_link_id[ 0 ] ].name ));; | |||
emwang-jump
reviewed
Feb 4, 2025
| int err = FD_MAP_ERR_AGAIN; | ||
| while( err == FD_MAP_ERR_AGAIN ) { | ||
| fd_buf_shred_map_query_t query[1] = { 0 }; | ||
| err = fd_buf_shred_map_query_try( blockstore->shred_map, &key, NULL, query ); |
There was a problem hiding this comment.
I think you also need to check here for FD_MAP_ERR_KEY etc, or else the following lines would segfault if the shred wasn't in the map.
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
2 times, most recently
from
7408543 to
ed04be5
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
5 times, most recently
from
ee73764 to
8408baf
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
from
8408baf to
1291ff9
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
from
1291ff9 to
5aea39c
Compare
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
2 times, most recently
from
030f411 to
fbbe91e
Compare
lidatong
force-pushed
the
chali/feat/blockstore-para
branch
from
fbbe91e to
8533b0a
Compare
ibhatt-jumptrading
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.