Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth, windows): add Windows support to auth plugin #11089

Merged
merged 148 commits into from
Sep 12, 2023
Merged

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jun 6, 2023

Description

Adding support to Windows for Auth.
Some feature are missing as per the Public Beta status of the Windows C++ SDK.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Lyokone added 30 commits April 17, 2023 14:13
@Lyokone Lyokone marked this pull request as ready for review September 7, 2023 08:58
@russellwheatley
Copy link
Member

russellwheatley commented Sep 7, 2023

Nice work, @Lyokone 🔥. Are we going to throw an UnimplementedError() in the method channel for the Auth API not available for Windows?

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking UnimplmentedException like the others 😄

Copy link
Contributor

@exaby73 exaby73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work my friend :) LGTM

@Lyokone Lyokone merged commit 0cedfc8 into master Sep 12, 2023
@Lyokone Lyokone deleted the feat/auth-windows branch September 12, 2023 12:54
milindgoel15 added a commit to milindgoel15/flutterfire that referenced this pull request Oct 11, 2023
@firebase firebase locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants