Spelling #1086
Open
Spelling #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
May 30, 2024
| file a Github issue. | ||
| file a GitHub issue. |
| @@ -883,7 +883,7 @@ ui.start('#firebaseui-auth-container', { | |||
| provider: 'saml.myProvider', | |||
| providerName: 'MySAMLProvider', | |||
| // To override the full label of the button. | |||
| // fullLabel: 'Constractor Portal', | |||
There was a problem hiding this comment.
I couldn't figure out if this was Constructor, Contractor, or something else...
| @@ -59,7 +59,7 @@ var translatableMsgs = fullCountryData.map(function(countryData) { | |||
| console.log(translatableMsgs); | |||
|
|
|||
| // Make the JSON object reference the translatable messages. | |||
| // This is kind of hacky since we set the the value to a string containing the | |||
There was a problem hiding this comment.
duplicated words aren't technically spelling errors, but spell checkers have flagged them for decades...
| // Emulate that a 'u' is typed in to name input. | ||
| // Emulate that a 'u' is typed into name input. |
There was a problem hiding this comment.
in to/into tend to be controversial. I believe typed into <container> is the appropriate preposition form, as opposed to typed in <to name [the] input>.
| @@ -54,7 +54,7 @@ function setUp() { | |||
| credentialObject = { | |||
| 'providerId': 'google.com', | |||
| 'signInMethod': 'google.com', | |||
| 'oauthAcessToken': 'ACCESS_TOKEN' | |||
There was a problem hiding this comment.
it's possible this was an intentional typo... for intentional typos, I encourage using trailing _s to make it clear that the item isn't the real thing...
| @@ -680,7 +680,7 @@ firebaseui.auth.AuthUI.prototype.initializeForAutoUpgrade_ = function(cb) { | |||
| * null otherwise. | |||
| * @private | |||
| */ | |||
| firebaseui.auth.AuthUI.prototype.getUpgradableUser_ = function() { | |||
| firebaseui.auth.AuthUI.prototype.getUpgradeableUser_ = function() { | |||
There was a problem hiding this comment.
It's possible this is a public api, in which case I can drop this change. I assumed it wasn't given the _ tail.
| 'text is really really long.', | ||
| 'text is really, really, long.', |
There was a problem hiding this comment.
often duplicate words are errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/firebaseui-web/actions/runs/9295504752#summary-25582508691
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/firebaseui-web/actions/runs/9295504869#summary-25582509055