Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition with App Check callback #984

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Fix race condition with App Check callback #984

merged 4 commits into from
Apr 15, 2024

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Apr 4, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/8577642704

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

#877

@a-maurice a-maurice requested a review from jonsimantov April 9, 2024 22:54
@a-maurice a-maurice requested a review from cynthiajoan April 15, 2024 20:36
@a-maurice a-maurice merged commit 956b072 into main Apr 15, 2024
4 checks passed
@a-maurice a-maurice deleted the am-app_check_fix branch April 15, 2024 20:41
@firebase firebase locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan