Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mila/count update api surface #6589

Merged
merged 13 commits into from
Sep 13, 2022
Merged

Mila/count update api surface #6589

merged 13 commits into from
Sep 13, 2022

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 7, 2022 •
edited
Loading

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a4a3ba9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL changed the base branch from master to mila/count September 7, 2022 18:10
@milaGGL milaGGL requested a review from dconeybe September 7, 2022 21:54
@milaGGL milaGGL marked this pull request as ready for review September 8, 2022 20:42
@milaGGL milaGGL requested review from dconeybe and removed request for dwyfrequency and hsubox76 September 8, 2022 20:42
dconeybe
dconeybe requested changes Sep 9, 2022
View reviewed changes
packages/firebase/compat/index.d.ts Show resolved Hide resolved
packages/firestore/src/api/aggregate.ts Outdated Show resolved Hide resolved
packages/firestore/src/api/aggregate.ts Outdated Show resolved Hide resolved
packages/firestore/src/api/aggregate.ts Outdated Show resolved Hide resolved
packages/firestore/src/api/aggregate.ts Outdated Show resolved Hide resolved
repo-scripts/prune-dts/tests/firestore.output.d.ts Outdated Show resolved Hide resolved
packages/firestore/test/lite/integration.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/lite/integration.test.ts Outdated Show resolved Hide resolved
packages/firestore/src/lite-api/aggregate.ts Outdated Show resolved Hide resolved
packages/firestore/src/lite-api/aggregate.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe September 9, 2022 20:37
dconeybe
dconeybe requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few minor pieces of feedback.

packages/firestore/src/core/firestore_client.ts Outdated Show resolved Hide resolved
packages/firestore/src/remote/datastore.ts Outdated Show resolved Hide resolved
packages/firestore/test/lite/integration.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/lite/integration.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/lite/integration.test.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe September 12, 2022 22:24
@milaGGL milaGGL merged commit 0ebab69 into mila/count Sep 13, 2022
@milaGGL milaGGL deleted the mila/count-update-API-surface branch September 13, 2022 03:52
@firebase firebase locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @dconeybe