Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create sample count test cases #6506

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Aug 4, 2022

Test cases are failing cause the current COUNT API is only returning dummy count 42.
Screen Shot 2022-08-04 at 10 09 58 AM

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: 2200b5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL self-assigned this Aug 4, 2022
@milaGGL milaGGL requested a review from dconeybe August 4, 2022 17:10
@dconeybe
Copy link
Contributor

dconeybe commented Aug 4, 2022

Looks great. Go ahead and merge. Then... make those tests pass!

@dconeybe dconeybe removed their assignment Aug 4, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2022

@milaGGL milaGGL merged commit 981e6f1 into mila/count Aug 4, 2022
@milaGGL milaGGL deleted the mila/count-add-sample-test-cases branch August 4, 2022 18:24
@firebase firebase locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants