Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile protos and upload the generated json file #6491

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jul 29, 2022

compiled the proto files added/created and add the proto.json file that is generated.

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

⚠️ No Changeset found

Latest commit: 25d32c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"type": "string",
"id": 1,
"options": {
"(google.api.field_behavior)": "REQUIRED"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto3 deprecated the "required". This should be a tag only, wouldn't have any side effects, right? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what effects it has, to be honest. But it is definitely different from proto2's "required" keyword. You can just assume it's correct since it's used elsewhere in the protos.

@milaGGL
Copy link
Contributor Author

milaGGL commented Jul 29, 2022

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dconeybe
Copy link
Contributor

wonder why this PR doesn't have compiled proto files in it: https://github.com/firebase/firebase-android-sdk/pull/3847/files

That is because the Android build system will compile the .proto files into .java files at build time. Our TypeScript build setup does not have that feature. Therefore, we need to compile the protos manually and check them into source control.

@milaGGL milaGGL merged commit 598e948 into mila/count Jul 29, 2022
@milaGGL milaGGL deleted the mila/count-add-protos-json branch July 29, 2022 19:50
@firebase firebase locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants