Update @rollup/plugin-node-resolve #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
avolkovi,
ChaoqunCHEN,
davideast,
Feiyang1,
hiranya911,
jamesdaniels,
sam-gc and
yuchenshi
as code owners
hsubox76
force-pushed
the
ch-node-resolve
branch
from
3a1001f to
43e662b
Compare
|
Size Analysis Report |
hsubox76
changed the title
Feiyang1
reviewed
Mar 2, 2021
| resolveOptions.customResolveOptions = { | ||
| moduleDirectory | ||
| }; | ||
| resolveOptions.moduleDirectories = [moduleDirectory]; |
There was a problem hiding this comment.
Nice! How did you catch the problem?
There was a problem hiding this comment.
I mean, it errors if you try to run it with the upgraded plugin, so I checked the changelog for breaking changes and this was there.
Feiyang1
approved these changes
Mar 2, 2021
1 task
hsubox76
force-pushed
the
ch-node-resolve
branch
from
43e662b to
5d7f555
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update @rollup/plugin-node-resolve dependency as attempted by this Renovate PR: #4162
Requires one small fix due to breaking change described here: rollup/plugins#656