Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate notice CI #14492

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix generate notice CI #14492

merged 2 commits into from
Feb 25, 2025

Conversation

paulb777
Copy link
Member

Fix #14491

#no-changelog

andrewheard
andrewheard approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

ncooke3
ncooke3 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought that the notices Gemfile's cocoapods version would need to be equal to the Cocoapods versions in our podspecs. Is there no relation?

@paulb777
Copy link
Member Author

The CocoaPods version in our podspecs is the minimum known supported CocoaPods version. They should work with anything later. The Gemfile specifies the version of CocoaPods being used.

@paulb777 paulb777 merged commit df200d7 into main Feb 25, 2025
25 checks passed
@paulb777 paulb777 deleted the pb-fix-notices branch February 25, 2025 17:03
@ncooke3
Copy link
Member

ncooke3 commented Feb 25, 2025

Thanks, @paulb777 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants
@paulb777 @ncooke3 @andrewheard