Fix Firestore import ordering

firebase · Jan 27, 2025 · 4bf3b54 · 4bf3b54
1 parent 4ac9019
commit 4bf3b54
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/Firestore/core/src/nanopb/byte_string.cc b/Firestore/core/src/nanopb/byte_string.cc
@@ -16,8 +16,9 @@
 
 #include "Firestore/core/src/nanopb/byte_string.h"
 
-#include <cctype>
 #include <cstdlib>
+
+#include <cctype>
 #include <cstring>
 #include <iomanip>
 #include <ostream>

diff --git a/Firestore/core/test/unit/nanopb/byte_string_test.cc b/Firestore/core/test/unit/nanopb/byte_string_test.cc
@@ -16,9 +16,10 @@
 
 #include "Firestore/core/src/nanopb/byte_string.h"
 
-#include <cstdint>
 #include <cstdlib>
 
+#include <cstdint>
+
 #include "Firestore/core/src/nanopb/nanopb_util.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"

diff --git a/Firestore/core/test/unit/util/executor_test.cc b/Firestore/core/test/unit/util/executor_test.cc
@@ -16,10 +16,11 @@
 
 #include "Firestore/core/test/unit/util/executor_test.h"
 
+#include <cstdlib>
+
 #include <chrono>              // NOLINT(build/c++11)
 #include <condition_variable>  // NOLINT(build/c++11)
-#include <cstdlib>
-#include <future>  // NOLINT(build/c++11)
+#include <future>              // NOLINT(build/c++11)
 #include <string>
 #include <thread>  // NOLINT(build/c++11)
 

diff --git a/Firestore/core/test/unit/util/schedule_test.cc b/Firestore/core/test/unit/util/schedule_test.cc
@@ -16,8 +16,9 @@
 
 #include "Firestore/core/src/util/schedule.h"
 
-#include <chrono>  // NOLINT(build/c++11)
 #include <cstdlib>
+
+#include <chrono>  // NOLINT(build/c++11)
 #include <string>
 
 #include "Firestore/core/src/util/task.h"

diff --git a/scripts/check_lint.py b/scripts/check_lint.py
@@ -141,7 +141,7 @@ def lint_py(files):
     global _flake8_warned
     if not _flake8_warned:
       _flake8_warned = True
-      _logger.warn(textwrap.dedent(
+      _logger.warning(textwrap.dedent(
           """
           Could not find flake8 on $PATH; skipping python lint.
           Install with: