Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotless support for *.gradle.kts files #6399

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add spotless support for *.gradle.kts files #6399

merged 1 commit into from
Oct 22, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 22, 2024

The more we cover by the formatter the better.

That being said, support for groovy is broken. I hit diffplug/spotless#1922 when trying to use groovyGradle formatting.

The more we cover by the formatter the better.

That being said, support for groovy is broken. I hit
diffplug/spotless#1922 when trying to use
groovyGradle formatting.
@rlazo rlazo requested review from daymxn and emilypgoogle October 22, 2024 16:37
Copy link
Contributor

github-actions bot commented Oct 22, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

Test Results

 1 022 files  +2   1 022 suites  +2   35m 48s ⏱️ -26s
 5 809 tests +2   5 787 ✅ +2  22 💤 ±0  0 ❌ ±0 
11 703 runs  +4  11 659 ✅ +4  44 💤 ±0  0 ❌ ±0 

Results for commit 2f3421a. ± Comparison against base commit 99f4325.

Copy link
Collaborator

@emilypgoogle emilypgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the collapsed plugins blocks seem a bit odd, since it's expected to be edited with some regularity, I assume there's no way to change that though.

@rlazo rlazo merged commit 3afa1c4 into main Oct 22, 2024
260 of 262 checks passed
@rlazo rlazo deleted the rl.spotless.kts branch October 22, 2024 17:14
@firebase firebase locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants