Droth 3297 improve logging #2026
Conversation
…inktable Droth 3292 roadlinktable
…and masstransitStops
| "floating" -> stop.floating, | ||
| "linkSource" -> stop.linkSource.value, | ||
| "propertyData" -> stop.propertyData) | ||
| val bbox = LogUtils.time(logger, "TEST LOG massTransitStops construct bbox"){ |
There was a problem hiding this comment.
kannattaako nyt tätä operaatiota oikein logitaa, ei taida olla hirveen oleelinen samoin toi validate boudingbox mut ei tää nyt varmaan haitta.
There was a problem hiding this comment.
Lähinnä menin sillä periaatteella, että "ei jätetä mitään kiveä kääntämättä". Todennäköisesti turhaa lokittaa tätä mutta ei haittaakaan
There was a problem hiding this comment.
joo eipä se pahaa tee
| @@ -1340,7 +1340,7 @@ class RoadLinkService(val vvhClient: VVHClient, val eventbus: DigiroadEventBus, | |||
|
|
|||
| def enrichRoadLinksFromVVH(allVvhRoadLinks: Seq[VVHRoadlink]): Seq[RoadLink] = { | |||
| val vvhRoadLinks = allVvhRoadLinks.filterNot(_.featureClass == FeatureClass.WinterRoads) | |||
| LogUtils.time(logger,"TEST LOG roadLinkDataByLinkId"){getRoadLinkDataByLinkIds(vvhRoadLinks)} | |||
| LogUtils.time(logger,"TEST LOG roadLinkDataByLinkId, link count: " + vvhRoadLinks.size){getRoadLinkDataByLinkIds(vvhRoadLinks)} | |||
There was a problem hiding this comment.
TEST LOG roadLinkDataByLinkId -> TEST LOG enrich roadLinkDataByLinkId vaikkapa
| @@ -462,7 +462,7 @@ class RoadLinkService(val vvhClient: VVHClient, val eventbus: DigiroadEventBus, | |||
| Await.result(vvhClient.roadLinkChangeInfo.fetchByBoundsAndMunicipalitiesF(bounds, municipalities).zip(vvhClient.roadLinkData.fetchByMunicipalitiesAndBoundsF(bounds, municipalities)), atMost = Duration.Inf) | |||
| ) | |||
| withDynTransaction { | |||
| LogUtils.time(logger, "TEST LOG enrichRoadLinksFromVVH")( | |||
| LogUtils.time(logger, "TEST LOG enrichRoadLinksFromVVH, link count: " + links.size)( | |||
There was a problem hiding this comment.
TEST LOG enrichRoadLinksFromVVH from boundingbox request
| @@ -64,8 +65,12 @@ class ManoeuvreService(roadLinkService: RoadLinkService, eventBus: DigiroadEvent | |||
| } | |||
|
|
|||
| def getByBoundingBox(bounds: BoundingRectangle, municipalities: Set[Int]): Seq[Manoeuvre] = { | |||
| val roadLinks = roadLinkService.getRoadLinksFromVVH(bounds) | |||
| getByRoadLinks(roadLinks) | |||
| val roadLinks = LogUtils.time(logger, "TEST LOG manoeuvres get roadlinks by bbox") { | |||
There was a problem hiding this comment.
varmaan yhtenäisempää käyttää boundingbox sanaa kuin bbox, helpottaa filterointia kun vaan yksi formaatti
Lisätty lokituksiin linkkien määrät, lisätty tarkempaa lokitusta kääntymisrajoitukset ja joukkoliikenteen pysäkit tietolajeille