Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add target blank for link #41

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

helangeline
Copy link

@helangeline helangeline commented Oct 1, 2020

Problem

  • When click one of the link in home, user will leave your site

Solution

  • Add target blank, so user still on your page, and can see other link

Changes proposed in this Pull Request :

  • Add target blank for github contributors
  • Add target blank for menu

Other changes

  • Change the year of title in index, its still 2018 instead of 2020

@fineanmol fineanmol merged commit 900f69c into fineanmol:master Oct 2, 2020
Abhash-Chakraborty pushed a commit to Abhash-Chakraborty/Hacktoberfest2022 that referenced this pull request Oct 6, 2022
Merge pull request fineanmol#40 from aitoss/revert-39-main
Abhash-Chakraborty pushed a commit to Abhash-Chakraborty/Hacktoberfest2022 that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants