Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy dependency should be specified #85

Closed
Stigjb opened this issue Mar 8, 2020 · 3 comments · Fixed by #86
Closed

Numpy dependency should be specified #85

Stigjb opened this issue Mar 8, 2020 · 3 comments · Fixed by #86
Labels
feature New feature or request

Comments

@Stigjb
Copy link

Stigjb commented Mar 8, 2020

If you try to get an embedding without having Numpy installed in the Python environment, you get a panic. Is it possible to have Numpy be automatically installed as a dependency when you run pip install finalfusion?
@danieldk danieldk added the feature New feature or request label Mar 8, 2020
@danieldk
Copy link
Member

danieldk commented Mar 8, 2020 •
edited
Loading

I have to check if anything changed, but before it was not possible to specify such dependencies with pyo3-pack/maturin.

@danieldk
Copy link
Member

danieldk commented Mar 8, 2020

Ah, seems that this is now possible, I'll do a PR.

danieldk added a commit that referenced this issue Mar 8, 2020
@danieldk
Add numpy as an installation dependency
1d06528 
Seems that maturin now supports this. Fixes #85.
@danieldk danieldk mentioned this issue Mar 8, 2020
Merged
danieldk added a commit that referenced this issue Mar 8, 2020
@danieldk
Add numpy as an installation dependency
b301003 
Seems that maturin now supports this. Fixes #85.
danieldk added a commit that referenced this issue Mar 8, 2020
@danieldk
Add numpy as an installation dependency
a4ecb34 
Seems that maturin now supports this. Fixes #85.

(cherry picked from commit b301003)
@Stigjb
Copy link
Author

Stigjb commented Mar 8, 2020

That was quick, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add numpy as an installation dependency finalfusion/finalfusion-python
2 participants
@danieldk @Stigjb