Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support memory-mapped quantized storage #56

Closed
danieldk opened this issue Sep 4, 2019 · 1 comment · Fixed by #61
Closed

Support memory-mapped quantized storage #56

danieldk opened this issue Sep 4, 2019 · 1 comment · Fixed by #61
Assignees
@danieldk
Labels
feature New feature or request
Milestone
release-0.5

Comments

@danieldk
Copy link
Member

danieldk commented Sep 4, 2019

Support for this will be in the next finalfusion release. Update the finalfusion dependency once this is available.
@danieldk danieldk added the feature New feature or request label Sep 4, 2019
@danieldk danieldk added this to the Release 0.5 milestone Sep 4, 2019
@danieldk danieldk self-assigned this Sep 4, 2019
@danieldk
Copy link
Member Author

danieldk commented Sep 8, 2019 •
edited
Loading

finalfusion was updated in #58. I tested this locally and it works as expected, though I should probably add a small unit test. I'll take a look at that today or tomorrow and branch a new release after that.

danieldk added a commit that referenced this issue Sep 9, 2019
@danieldk
Add tests for reading/mmaping quantized embeddings
72da5a8 
Fixes #56.
@danieldk danieldk mentioned this issue Sep 9, 2019
Merged
danieldk added a commit that referenced this issue Sep 9, 2019
@danieldk
Add tests for reading/mmaping quantized embeddings
4f6db3c 
Fixes #56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldk danieldk

Labels
feature New feature or request
Milestone
release-0.5
Development

Successfully merging a pull request may close this issue.

Add tests for reading/mmaping quantized embeddings finalfusion/finalfusion-python
1 participant
@danieldk