Hypergrid v3.2.0 #780
Merged
Hypergrid v3.2.0 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mouse event details
Add Base.prototype.versionAtLeast
Add Registry.prototype.make
Add support for themeable SVG images
Bump version number to v3.2.0
Update README to 3.2.0
Resolve jsdoc compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
Base.prototype.versionAtLeast(see PR Add Base.prototype.versionAtLeast #777)Registry.prototype.make(see PR Add Registry.prototype.make #775)Change regarding Versioning
Going forward and starting with this release, we shall bump the minor version number (middle tupple of version number) on any new functionality per npm SEMVER.
Previously we were often just bumping the patch number (last tupple), but patches are meant for bug fixes that do not introduce any new functionality. The interface for a minor version bump is non-breaking/backwards compatible. It may however be expanded (new parameters); just so long as it doesn't break existing code.
Change regarding pull requests
Going forward and starting with this release, we shall be switching over to the single-item-per-PR paradigm (where "item" is a bug fix or new feature implementation).
Previously we were putting an entire release's items into a single branch/PR with separate commits per item. This was easy to work with for me as the only active contributor because commits therein could be based on earlier commits without intermediate merges. Besides not being conducive to multiple contributors, however, it was difficult (impossible really) to get anyone to code review a big PR. Doing so requires reviewing each commit one by one. GitHub conversations are better supported at the PR level rather than at the commit level.
Also, note that constant rebasing is not necessary just to move the commit ahead of develop before the merge. The resulting
git logleap-frogging railroad diagrams are still easily comprehensible. Only rebase when there are are actual merge conflicts (which GitHub checks will tell you). After all, during a PR merge, git applies the exact same merge algorithms as would be performed in a rebase with no conflicts.A release PR (merge-to-master) also reflect a final PR that bumps the version number.
This change in strategy should make reviewing less daunting and hopefully we'll get more feedback before merging.