Skip to content

Commit

Permalink
Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in con…
Browse files Browse the repository at this point in the history
…figs #2
  • Loading branch information
KarlK90 committed Dec 12, 2022
1 parent c118e38 commit f46f9e7
Show file tree
Hide file tree
Showing 18 changed files with 70 additions and 74 deletions.
2 changes: 1 addition & 1 deletion keyboards/adm42/rev4/keymaps/default/config.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#define HOLD_ON_OTHER_KEY_PRESS_PER_KEY
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY
6 changes: 3 additions & 3 deletions keyboards/adm42/rev4/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
}
}

bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LLS_ESC:
case LLS_RALT:
return true;
return 0;
default:
return false;
return QUICK_TAP_TERM;
}
}

Expand Down
2 changes: 1 addition & 1 deletion keyboards/ergodox_ez/keymaps/stamm/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY

#define QUICK_TAP_TERM 0
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY

/* #define RETRO_TAPPING */
#undef LED_BRIGHTNESS_DEFAULT
Expand Down
37 changes: 17 additions & 20 deletions keyboards/ergodox_ez/keymaps/stamm/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -225,28 +225,25 @@ bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
}
}


bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(_1_NUMBERS, KC_E):
case R_MOUSE:
case LSFT_T(KC_A):
case LCTL_T(KC_S):
case LALT_T(KC_D):
case LGUI_T(KC_F):
case RGUI_T(KC_J):
case RALT_T(KC_K):
case RCTL_T(KC_L):
case RSFT_T(KC_SEMICOLON):
case ARROWS:
return false;
default:
return true;
}
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(_1_NUMBERS, KC_E):
case R_MOUSE:
case LSFT_T(KC_A):
case LCTL_T(KC_S):
case LALT_T(KC_D):
case LGUI_T(KC_F):
case RGUI_T(KC_J):
case RALT_T(KC_K):
case RCTL_T(KC_L):
case RSFT_T(KC_SEMICOLON):
case ARROWS:
return QUICK_TAP_TERM;
default:
return 0;
}
}



LEADER_EXTERNS();

void matrix_scan_user(void) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define TAPPING_TERM_PER_KEY // milliseconds from tap to hold for mod tap per key
#define IGNORE_MOD_TAP_INTERRUPT // ignore hold mod if another tap occurs within tapping term
#define PERMISSIVE_HOLD_PER_KEY // activate mod top hold earlier if another key is pressed AND released per key
#define TAPPING_FORCE_HOLD_PER_KEY // disable double tap hold key repeat per key
#define QUICK_TAP_TERM_PER_KEY // disable double tap hold key repeat per key
#undef MOUSEKEY_INTERVAL
#undef MOUSEKEY_DELAY
#undef MOUSEKEY_TIME_TO_MAX
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ bool get_permissive_hold(uint16_t keycode, keyrecord_t *record) {
}

// Tapping force hold per key
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(3, KC_SPC):
return true; // Enable force hold
case LT(2, KC_TAB):
return true;
default:
return false; // Disable force hold
}
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(3, KC_SPC):
return 0; // Enable force hold
case LT(2, KC_TAB):
return 0;
default:
return QUICK_TAP_TERM; // Disable force hold
}
}

// Tapping term per key
Expand Down
2 changes: 1 addition & 1 deletion keyboards/planck/keymaps/adamtabrams/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@
#define IGNORE_MOD_TAP_INTERRUPT
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY
#define QUICK_TAP_TERM 0
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY
6 changes: 3 additions & 3 deletions keyboards/planck/keymaps/adamtabrams/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
return true;
}

bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case SHFTESC:
case NUMSPAC:
Expand All @@ -249,9 +249,9 @@ bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
case CTL__J:
case CTL__T:
case CTL__N:
return true;
return 0;
default:
return false;
return QUICK_TAP_TERM;
}
}

Expand Down
2 changes: 1 addition & 1 deletion keyboards/planck/keymaps/jweickm/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
#define TAPPING_TERM_PER_KEY
//#define PERMISSIVE_HOLD
#define IGNORE_MOD_TAP_INTERRUPT
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY

// settings for LEADER key
#define LEADER_PER_KEY_TIMING
Expand Down
24 changes: 12 additions & 12 deletions keyboards/planck/keymaps/jweickm/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1039,30 +1039,30 @@ bool music_mask_user(uint16_t keycode) {
}
}

bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LSFT_T(KC_S):
return true;
return 0;
case RSFT_T(KC_E):
return true;
return 0;
case LSFT_T(KC_D):
return true;
return 0;
case RSFT_T(KC_K):
return true;
return 0;
case LSFT_T(KC_F):
return true;
return 0;
case RSFT_T(KC_U):
return true;
return 0;
case LT(_RAISE, KC_ENT):
return true;
return 0;
case LT(_RAISE_DE, KC_ENT):
return true;
return 0;
case LT(_LOWER, KC_BSPC):
return true;
return 0;
case LT(_LOWER_DE, KC_BSPC):
return true;
return 0;
default:
return false;
return QUICK_TAP_TERM;
}
}

Expand Down
2 changes: 1 addition & 1 deletion keyboards/planck/keymaps/rootiest/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
* MACRO per-key options
*/
#define RETRO_TAPPING_PER_KEY // Control Retro-Tap individually by key
#define TAPPING_FORCE_HOLD_PER_KEY // Control Force-Hold individually by key
#define QUICK_TAP_TERM_PER_KEY // Control Quick-Tap individually by key
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY // Control Mod-Tap-Interrupt individually by key
#define PERMISSIVE_HOLD_PER_KEY // Control Permissive-Hold individually by key

Expand Down
6 changes: 3 additions & 3 deletions keyboards/planck/keymaps/rootiest/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1376,11 +1376,11 @@ bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t* record) {
return false;
}
}
// Handles per-key configuration of Tapping Force-Hold
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t* record) {
// Handles per-key configuration of Quick-Tap
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t* record) {
switch (keycode) {
default:
return false;
return QUICK_TAP_TERM;
}
}
// Handles per-key configuration of Permissive-Hold
Expand Down
2 changes: 1 addition & 1 deletion users/drashna/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
#if defined(PER_KEY_TAPPING)
# define IGNORE_MOD_TAP_INTERRUPT_PER_KEY
# define PERMISSIVE_HOLD_PER_KEY
# define TAPPING_FORCE_HOLD_PER_KEY
# define QUICK_TAP_TERM_PER_KEY
# define HOLD_ON_OTHER_KEY
# define RETRO_TAPPING_PER_KEY
# define HOLD_ON_OTHER_KEY_PRESS_PER_KEY
Expand Down
8 changes: 4 additions & 4 deletions users/drashna/keyrecords/tapping.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ __attribute__((weak)) bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrec
}
#endif // IGNORE_MOD_TAP_INTERRUPT_PER_KEY

#ifdef TAPPING_FORCE_HOLD_PER_KEY
__attribute__((weak)) bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
#ifdef QUICK_TAP_TERM_PER_KEY
__attribute__((weak)) uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
default:
return false;
return QUICK_TAP_TERM;
}
}
#endif // TAPPING_FORCE_HOLD_PER_KEY
#endif // QUICK_TAP_TERM_PER_KEY

#ifdef RETRO_TAPPING_PER_KEY
__attribute__((weak)) bool get_retro_tapping(uint16_t keycode, keyrecord_t *record) {
Expand Down
2 changes: 1 addition & 1 deletion users/dshields/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define ONESHOT_TIMEOUT 3000
#define IGNORE_MOD_TAP_INTERRUPT
#define PERMISSIVE_HOLD_PER_KEY
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY
#define TAPPING_TERM 200
#define BACKLIGHT_BREATHING
#define DYNAMIC_MACRO_NO_NESTING
Expand Down
7 changes: 3 additions & 4 deletions users/dshields/dshields.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
return true;
}

bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case MT_A:
case MT_S:
Expand All @@ -39,9 +39,9 @@ bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
case MT_K:
case MT_L:
case MT_SCLN:
return true;
return 0;
default:
return false;
return QUICK_TAP_TERM;
}
}

Expand All @@ -55,4 +55,3 @@ bool get_permissive_hold(uint16_t keycode, keyrecord_t *record) {
return false;
}
}

2 changes: 1 addition & 1 deletion users/ridingqwerty/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#define TAPPING_TERM 175
#define MACRO_TIMER 5
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM_PER_KEY
// testing
#define TAPPING_TERM_PER_KEY
//#define IGNORE_MOD_TAP_INTERRUPT // rolling R3 "zxcv", etc...
14 changes: 7 additions & 7 deletions users/ridingqwerty/ridingqwerty.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record) {
}
};

bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case NM(SCLN):
return true;
default:
return false;
}
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case NM(SCLN):
return 0;
default:
return QUICK_TAP_TERM;
}
}

0 comments on commit f46f9e7

Please sign in to comment.