Resolve o bug da mensagem "Conteúdo apagado com sucesso" #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cafesao
previously approved these changes
Nov 21, 2022
matheuslipk
previously approved these changes
Nov 25, 2022
JonathanArgentao
previously approved these changes
Nov 26, 2022
aprendendofelipe
force-pushed
the
deleted-content-bug
branch
from
56c33c8 to
35a8058
Compare
filipedeschamps
previously approved these changes
Dec 8, 2022
aprendendofelipe
dismissed stale reviews from filipedeschamps, JonathanArgentao, matheuslipk, and cafesao
via
a687cb8
|
Olha só @filipedeschamps, para matar a dúvida fiz o seguinte teste: Você já tinha aprovado e já estava habilitado o merge nesse PR. Então fiz um commit pra corrigir a meta tag adicionada pelo @gabrielsozinho no PR #1110 (só mudei para CamelCase para parar de dar erros no console). E com esse novo commit a sua aprovação foi cancelada e desabilitou o botão de merge conforme o esperado, mesmo sem aquela proteção da branch habilitada 😉 |
filipedeschamps
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adiciona uma
keyao conteúdorootechildren(fix #808).No
childrenfoi mais pensando em performance do React, mas não tem influência no bug.Ah, mas utilizou a mesma chave para os dois e para o componente
compact. Pode isso?Excelente pergunta! E pode sim!
A chave precisa ser única apenas entre seus elementos irmãos. Elas não precisam ser únicas globalmente.