Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(header): set header link to active (#675) #678

Merged
merged 2 commits into from
Aug 25, 2022
Merged

feat(header): set header link to active (#675) #678

merged 2 commits into from
Aug 25, 2022

Conversation

filipedeschamps
Copy link
Owner

@filipedeschamps filipedeschamps commented Aug 24, 2022 •
edited
Loading

PR intermediário do PR #675 do @gpaiva00 para forçar deploy em Homologação 🤝

@vercel
Copy link

vercel bot commented Aug 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabnews ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 10:07PM (UTC)

@vercel
Copy link

vercel bot commented Aug 24, 2022

@gpaiva00 is attempting to deploy a commit to the TabNews Team on Vercel.

To accomplish this, @gpaiva00 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@filipedeschamps
Copy link
Owner Author

Puts, falhou o deploy porque o squash não adicionou um último commit com meu user. 1 segundo 👍

@filipedeschamps
Copy link
Owner Author

@gpaiva00 dois detalhes que fiz no commit f24e8a7

  1. Usei o método startsWith para garantir o match no pathname e evitar surpresas se algum dia alguma outra URL também conter as palavras recentes ou status.
  2. Mas o mais importante foi a alteração sobre a estilização no Relevantes para considerar a paginação dela, onde o pathname nesse caso é diretamente /pagina 🤝

Já está em homologação: https://tabnews-git-preview-tabnews.vercel.app/

Vamos para o merge na main? 😍

@filipedeschamps filipedeschamps mentioned this pull request Aug 24, 2022
Closed
gpaiva00
gpaiva00 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@gpaiva00 gpaiva00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@filipedeschamps filipedeschamps merged commit ca045b5 into main Aug 25, 2022
@filipedeschamps filipedeschamps deleted the preview branch August 25, 2022 14:56
@filipedeschamps
Copy link
Owner Author

Merged!!! Let's gooooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpaiva00 gpaiva00 gpaiva00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipedeschamps @gpaiva00