Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert remaining big.int wrapper types to use leb128 encoding #580

Merged
merged 0 commits into from
Jun 21, 2018
Merged

convert remaining big.int wrapper types to use leb128 encoding #580

merged 0 commits into from
Jun 21, 2018

Conversation

phritz
Copy link
Contributor

@phritz phritz commented Jun 21, 2018

Work towards #340. All that remains to convert are primitive types.

@phritz phritz requested review from acruikshank and frrist June 21, 2018 17:52
@phritz phritz changed the title convertr remaining bit.int wrapper types to use leb128 encoding convert remaining bit.int wrapper types to use leb128 encoding Jun 21, 2018
@phritz phritz changed the title convert remaining bit.int wrapper types to use leb128 encoding convert remaining big.int wrapper types to use leb128 encoding Jun 21, 2018
acruikshank
acruikshank approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@acruikshank acruikshank left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I'm concerned about the test failure.

@phritz phritz removed the request for review from frrist June 21, 2018 20:46
@phritz phritz force-pushed the feat/lebobjs branch 2 times, most recently from d373bc1 to 96d8a71 Compare June 21, 2018 22:36
@phritz
Copy link
Contributor Author

phritz commented Jun 21, 2018

Man the tests are really flaky. Forrest thinks the failures are #583. Merging.

@phritz phritz merged commit c35f160 into master Jun 21, 2018
@phritz phritz deleted the feat/lebobjs branch June 21, 2018 22:46
@mishmosh mishmosh added this to the Sprint 15 milestone Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboodman aboodman aboodman approved these changes

@acruikshank acruikshank acruikshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.
4 participants
@phritz @aboodman @acruikshank @mishmosh