Use leb128 encoding for token amounts #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboodman
approved these changes
Jun 19, 2018
aboodman
reviewed
Jun 20, 2018
| ta := NewZeroAttoFIL() | ||
| _, ok := ta.val.SetString(s, base) | ||
| return ta, ok | ||
| af := NewZeroAttoFIL() |
There was a problem hiding this comment.
that's gonna be a fun abbreviation
aboodman
approved these changes
Jun 20, 2018
frrist
approved these changes
Jun 20, 2018
actor/builtin/miner/miner_test.go
Outdated
| @@ -52,7 +52,7 @@ func TestAddAsk(t *testing.T) { | |||
|
|
|||
| result, err := core.ApplyMessage(ctx, st, msg, types.NewBlockHeight(0)) | |||
| assert.NoError(err) | |||
| assert.Equal(types.NewAttoFILFromFIL(0), types.NewAttoFILFromBytes(result.Receipt.Return[0])) | |||
| assert.True(big.NewInt(0).Cmp(big.NewInt(0).SetBytes(result.Receipt.Return[0])) == 0) | |||
There was a problem hiding this comment.
nit: can we keep this as an Equal check? I like seeing expect: 0 actual: -1 in test failures better than telling me something was false
types/atto_fil.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
| "math/big" | |||
|
|
|||
| cbor "gx/ipfs/QmRiRJhn427YVuufBEHofLreKWNw7P7BWNq86Sb9kzqdbd/go-ipld-cbor" | |||
| leb128 "gx/ipfs/QmSKyB5faguXT4NqbrXpnRXqaVj5DhSm7x9BtzFydBY1UK/go-leb128" | |||
There was a problem hiding this comment.
nit: adding leb128 is redundant (cbor above is as well)
There was a problem hiding this comment.
learn something new every day. my editor wont let me drop the cbor one but it lets me drop the leb128, blame goreturns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work towards #340.