Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update venus-auth go mod for 'trustedhandle' #4519

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Aug 9, 2021

Motivation

sub-uri of 'pprof' is forbidden.

Proposed changes

change the logical of 'TrustHandle' to following description:
if 'pattern' with '/' as suffix, 'TrustHandler' treat it as a root path,
that it's all sub-path would be trusted.
if 'pattern' without '/' suffix,
only the URI exactly matches the 'pattern' would be treat as trusted.

Closes #

@codecov-commenter
Copy link

Codecov Report

Merging #4519 (0cc459b) into master (4a26be1) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4519   +/-   ##
======================================
- Coverage      31%     31%   -1%     
======================================
  Files         249     249           
  Lines       23487   23487           
======================================
- Hits         7347    7324   -23     
- Misses      14787   14802   +15     
- Partials     1353    1361    +8     

@hunjixin hunjixin merged commit e244039 into master Aug 9, 2021
@zl03jsj zl03jsj deleted the fix/trusted-uri branch July 14, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants