-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protect wallet password and private key #4427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4427 +/- ##
======================================
Coverage 30% 30%
======================================
Files 249 248 -1
Lines 20240 20219 -21
======================================
+ Hits 6084 6134 +50
+ Misses 12852 12790 -62
+ Partials 1304 1295 -9 |
9464877
to
de08bfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty promising! There are still a few cases where the keys escape memguard's protection, and I flagged everything I could find throughout the call graph. I did not flag the same issues with the password enclaves, but ideally they also would not leave memguard protected memory. I am aware this is not always possible because you have to deal with external APIs such as scrypt.
I think this biggest step was taken, because the key are only in insecure memory for a very short time, i.e. during processing. The biggest danger came from the long-term storage of keys, which is not encrypted.
069f02f
to
3dbcf07
Compare
3dbcf07
to
b95ca71
Compare
Motivation
Proposed changes
Closes #