Add reserved exit codes and remove commented-out ones #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2100 +/- ##
=======================================
Coverage 75.96% 75.96%
=======================================
Files 154 154
Lines 15771 15771
=======================================
Hits 11980 11980
Misses 3791 3791
|
elmattic
requested review from
anorth and
Stebalien
and removed request for
anorth
|
Really, these shouldn't have been exported anywhere. Are you actually seeing these error codes? |
|
If you are running into them in practice, we need to rename those to something else like (deprecated X). |
I believe I've seen some of them while testing I'm good if we don't defined them. Let's close this PR then. |
|
SGTM. If you do notice one, please report a bug and we'll rename it to something sane (i.e., "deprecated X" instead of "reserved X"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes reserved exit codes and removes others that are likely unnecessary.
The rationale is that for certain endpoints in the Ethereum RPC-API (e.g.,
Filecoin.EthTraceBlock), aligning Forest's JSON output with Lotus's output is important.Having these exit codes available will help in the
forest-tool api comparetool.See go-state-types exit codes and traceErrMsg that we want to match in Forest.