Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ux: Check for client deal addrs on-chain #8830

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jun 9, 2022

Checks if the address used in lotus client deal is "initialized" on-chain before running the uiLoop.

Related Issues

Resolves #8817

Proposed Changes

Adds a check to see if the actor (address in this case) is on chain before starting the lotus client deal - interactiveDeal uiLoop

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Checks if the address used in `lotus client deal` is "initialized" on-chain before running the `uiLoop`. Resolves #8817
@rjan90 rjan90 requested a review from a team as a code owner June 9, 2022 14:24
@rjan90 rjan90 changed the title fix: ux: client deal addrs is on-chain check fix: ux: Check for client deal addrs on-chain Jun 15, 2022
@geoff-vball geoff-vball merged commit 5c884b5 into master Jun 17, 2022
@geoff-vball geoff-vball deleted the fix/error-client-deal branch June 17, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message enhancement: "actor not found" (aka Insufficient FIL)
2 participants