feat: implement Lotus F3 CLI finality cert get and list #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
changed the title
masih
force-pushed
the
masih/lotus-f3-cli-cert-get-list
branch
2 times, most recently
from
81dc793 to
5cd2bd8
Compare
Implement `lotus f3` CLI sub commands to: * Get a specific finality certificate, either latest or by instance ID. * List a range of finality certificates Part of #12607
masih
force-pushed
the
masih/lotus-f3-cli-cert-get-list
branch
from
c808203 to
97ca0b1
Compare
Stebalien
reviewed
Oct 23, 2024
Stebalien
reviewed
Oct 23, 2024
Stebalien
reviewed
Oct 23, 2024
Stebalien
reviewed
Oct 23, 2024
21 tasks
Stebalien
approved these changes
Oct 24, 2024
|
Merging as-is, we can always iterate later. |
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
Implement `lotus f3` CLI sub commands to: * Get a specific finality certificate, either latest or by instance ID. * List a range of finality certificates Part of #12607
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
Implement `lotus f3` CLI sub commands to: * Get a specific finality certificate, either latest or by instance ID. * List a range of finality certificates Part of #12607
masih
added a commit
that referenced
this pull request
Nov 1, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment)
8 tasks
masih
added a commit
that referenced
this pull request
Nov 1, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment)
Stebalien
pushed a commit
that referenced
this pull request
Nov 1, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment)
masih
added a commit
that referenced
this pull request
Nov 4, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment) (cherry picked from commit 773efae)
rjan90
pushed a commit
that referenced
this pull request
Nov 6, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment) (cherry picked from commit 773efae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Implement
lotus f3CLI sub commands to:Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: