Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: daemon: ensure imports are unaffected by remote-EOF #12542

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

ribasushi
Copy link
Collaborator

While testing snapshot imports from a cold-start

lotus daemon --remove-existing-chain=true --import-snapshot https://forest-archive.chainsafe.dev/latest/calibnet

I encountered the process aborting with an unexpected

...
2024-10-02T12:10:57.487+0200	INFO	badgerbs	[email protected]/levels.go:1010	[Compactor: 0] Compaction for level: 1 DONE
4.38 GiB / 4.38 GiB [----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 24.52 MiB p/s 3m3s
2024-10-02T12:11:09.056+0200	WARN	chainstore	store/store.go:670	reorgWorker quit
2024-10-02T12:11:09.058+0200	INFO	badgerbs	[email protected]/db.go:1027	Storing value log head: {Fid:8 Len:32 Offset:276003168}

2024-10-02T12:11:09.190+0200	INFO	badgerbs	[email protected]/levels.go:1000	[Compactor: 173] Running compaction: {level:0 score:1.73 dropPrefixes:[]} for level: 0

2024-10-02T12:11:10.036+0200	INFO	badgerbs	[email protected]/levels.go:962	LOG Compact 0->1, del 5 tables, add 5 tables, took 846.318625ms

2024-10-02T12:11:10.036+0200	INFO	badgerbs	[email protected]/levels.go:1010	[Compactor: 173] Compaction for level: 0 DONE
2024-10-02T12:11:10.036+0200	INFO	badgerbs	[email protected]/db.go:550	Force compaction on level 0 done
ERROR: importing chain failed: failed to read from underlying reader: http2: response body closed

see in-code comment explaining the fix

@ribasushi ribasushi requested a review from magik6k October 2, 2024 10:12
@ribasushi ribasushi added the skip/changelog This change does not require CHANGELOG.md update label Oct 2, 2024
@ribasushi ribasushi requested a review from masih October 2, 2024 10:20
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @ribasushi

ribasushi and others added 2 commits October 2, 2024 12:27
@rvagg rvagg enabled auto-merge (squash) October 2, 2024 10:28
@rvagg rvagg merged commit 36a3bda into filecoin-project:master Oct 2, 2024
81 checks passed
@ribasushi ribasushi deleted the fix/import branch October 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants