fix: build: Ensure Quicknet is used when spinning up 2k/butterfly networks #12175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to always use quicknet in 2k-net
Update params_2k.go
Update to always use DrandQuicknet in Butterfly/Interop
rjan90
added a commit
that referenced
this pull request
Jul 4, 2024
…works (#12175) * Update to always use quicknet in 2k-net Update to always use quicknet in 2k-net * Update params_2k.go Update params_2k.go * Update to always use DrandQuicknet in Butterfly/Interop Update to always use DrandQuicknet in Butterfly/Interop
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since
GenesisNetworkVersion?is set to network.Version22, and the upgradeUpgradePhoenixHeight = abi.ChainEpoch(-25)- we are never triggering the switch Quicknet in 2k-networks and butterfly-networks.This ensure that we start using Quicknet from start.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps