Audit config section, populate advanced-config section #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lotus-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 6 commits
April 20, 2022 19:00
rjan90
reviewed
Apr 29, 2022
rjan90
reviewed
Apr 29, 2022
|
@TippyFlitsUK @rjan90 @Reiers Can you please add information to the logging page? I need help with Rust logs. It is marked as TODO. |
Co-authored-by: TippyFlits <[email protected]>
johnnymatthews
suggested changes
May 2, 2022
There was a problem hiding this comment.
Changes needed:
- When mentioning the Lotus miner application, always surround it in quotes and add a dash. So
lotus-miner, not Lotus miner. - Don't use quote blocks for call outs.
- If files have moved around you need to add redirects/aliases.
There are a lot of changes in this PR. Next time, split your changes between multiple smaller PRs, it makes things much easier to review and figure out what's going wrong when something breaks.
content/en/storage-providers/advanced-configurations/logging.md
Outdated
Show resolved
Hide resolved
content/en/storage-providers/advanced-configurations/logging.md
Outdated
Show resolved
Hide resolved
content/en/storage-providers/advanced-configurations/logging.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Johnny <[email protected]>
johnnymatthews
approved these changes
May 2, 2022
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parts of #77
Empty config section
Check links
Check aliases are in place
Rename config section to Setup
Add pre-requisite page
Make changes in menu
Do final check for 404 or incorrect redirects
Populate logging page - Separate rust log file