-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate FIP-0045 changes into verifreg, miner, market #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e66489
to
ad0c1be
Compare
dd62707
to
283fc79
Compare
283fc79
to
6748c00
Compare
5 tasks
c481def
to
0d3cdee
Compare
c1fd4fc
to
927c7e6
Compare
geoff-vball
commented
Sep 28, 2022
geoff-vball
commented
Sep 28, 2022
3f1d5af
to
ec09f6c
Compare
ec09f6c
to
64848d1
Compare
arajasek
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes needed
Co-authored-by: Aayush Rajasekaran <[email protected]>
7a080f0
to
ad92aaf
Compare
arajasek
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still got the one FIXME, but otherwise g2g
16e71cb
to
e66efe2
Compare
arajasek
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57, #72, #73, #74, #75