Use the latest computed power table instead of always ranging certs #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certificate store already keeps track of the latest power table, i.e., the power table of the next expected certificate. Use this pre-computed table whenever the next power table is asked for instead of re-computing it every time. This results in a much faster response to `GetPowerTable` for the most common case: getting the committee as part of monotonic progress of GPBFT instances. Fixes #881
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 67.11% 67.24% +0.12%
==========================================
Files 85 85
Lines 9175 9185 +10
==========================================
+ Hits 6158 6176 +18
+ Misses 2468 2464 -4
+ Partials 549 545 -4
|
|
Has been running on butterflynet since ~1200 UTC. Get committee times looking much better: |
Stebalien
approved these changes
Feb 7, 2025
| if instance > nextCertInstance { | ||
| return nil, fmt.Errorf("cannot return future power table for instance %d > %d", instance, nextCertInstance) | ||
| } | ||
| if instance == nextCertInstance && len(latestPowerTable) != 0 { |
There was a problem hiding this comment.
Instead of checking len(latestPowerTable), can we check latestCert != nil? I guess that won't work for instance 0... meh, this works fine.
There was a problem hiding this comment.
Yes, it would be problematic for firstInstance. An alternative is to explicitly check if the instance is the same as firstInstance. But that makes up a more complicated logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate store already keeps track of the latest power table, i.e., the power table of the next expected certificate. Use this pre-computed table whenever the next power table is asked for instead of re-computing it every time.
This results in a much faster response to
GetPowerTablefor the most common case: getting the committee as part of monotonic progress of GPBFT instances.Fixes #881