Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag status in encoding time metrics #873

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Tag status in encoding time metrics #873

merged 1 commit into from
Feb 5, 2025

Conversation

masih
Copy link
Member

@masih masih commented Feb 5, 2025

Tag the encoding time measurements with success/failure.

Fixes inconsistent error check across defer statements measuring time.

Tag the encoding time measurements with success/failure.

Fixes inconsistent error check across `defer` statements measuring time.
@masih masih requested a review from Stebalien February 5, 2025 16:06
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.18%. Comparing base (146ffe4) to head (d71d453).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   67.11%   67.18%   +0.07%     
==========================================
  Files          84       85       +1     
  Lines        9175     9174       -1     
==========================================
+ Hits         6158     6164       +6     
+ Misses       2469     2465       -4     
+ Partials      548      545       -3     
Files with missing lines Coverage Δ
internal/encoding/encoding.go 80.95% <100.00%> (+10.83%) ⬆️
internal/encoding/metrics.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@masih masih added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit fd8b246 Feb 5, 2025
14 checks passed
@masih masih deleted the masih/encoding-err branch February 5, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants