Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalize API to EC backend #642

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add finalize API to EC backend #642

merged 1 commit into from
Sep 18, 2024

Conversation

masih
Copy link
Member

@masih masih commented Sep 13, 2024

Expand the F3 EC backend API to mark a given tipset as final. This translates to checkpointing the tipset in Lotus beyond which no forks are allowed.

Part of #603

@masih masih requested review from Kubuxu and Stebalien September 13, 2024 10:49
@masih masih force-pushed the masih/ec-finalize-api branch from 932b806 to a47f60f Compare September 13, 2024 10:49
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.40%. Comparing base (92a5658) to head (2a18b1d).

Files with missing lines Patch % Lines
host.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   80.02%   79.40%   -0.62%     
==========================================
  Files          52       52              
  Lines        4695     4700       +5     
==========================================
- Hits         3757     3732      -25     
- Misses        590      610      +20     
- Partials      348      358      +10     
Files with missing lines Coverage Δ
internal/consensus/fake_ec.go 89.88% <100.00%> (+0.11%) ⬆️
host.go 70.30% <20.00%> (-0.73%) ⬇️

... and 6 files with indirect coverage changes

@masih masih force-pushed the masih/ec-finalize-api branch from a47f60f to 3f40360 Compare September 13, 2024 14:03
@BigLep BigLep linked an issue Sep 13, 2024 that may be closed by this pull request
@masih masih force-pushed the masih/ec-finalize-api branch 2 times, most recently from c770a32 to 8441263 Compare September 17, 2024 13:47
@masih masih force-pushed the masih/ec-finalize-api branch 4 times, most recently from 37d04b6 to 2789b6f Compare September 18, 2024 10:17
Expand the F3 EC backend API to mark a given tipset as final. This
translates to checkpointing the tipset in Lotus beyond which no forks
are allowed.

Part of #603
@masih masih force-pushed the masih/ec-finalize-api branch from 2789b6f to 84532af Compare September 18, 2024 10:21
@masih masih added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit cc35ea0 Sep 18, 2024
11 checks passed
@masih masih deleted the masih/ec-finalize-api branch September 18, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make F3 consensus final
2 participants