Refactor replica update sector info to new method #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
+ Coverage 90.80% 91.00% +0.19%
==========================================
Files 145 145
Lines 27402 27372 -30
==========================================
+ Hits 24883 24909 +26
+ Misses 2519 2463 -56
|
ZenGround0
reviewed
Aug 17, 2023
ZenGround0
approved these changes
Aug 17, 2023
| continue; | ||
| } | ||
|
|
||
| if update.replica_proof.len() > 4096 { |
There was a problem hiding this comment.
This might be a good opportunity to make this magic number a constant somewhere
There was a problem hiding this comment.
(not worth blocking Im planning to merge once tests pass)
| .context_code(ExitCode::USR_ILLEGAL_STATE, "couldn't load update proof type")?; | ||
| if update.update_proof_type != expected_proof_type { | ||
| info!("unsupported update proof type {}", i64::from(update.update_proof_type)); | ||
| continue; |
There was a problem hiding this comment.
nit: For a future where this is called by a snark pack aggregate super snap method -- Im suspicious we might want to just fail the whole thing early here. Don't think you need to do anything in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended as a pure refactor. This doesn't get all of the re-usable code out, but a big step.