BACKPORT hashicorp#27390 fix resource/aws_ecs_service: make task_definition truly optional #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusunglee
changed the title
caesarxuchao
approved these changes
Oct 24, 2022
|
@caesarxuchao Yes we'll have to update the provider version in the terraform code We can copy this: https://github.com/figma/figma/pull/79294 |
This reverts commit a23db3e.
|
I assume I will also need to manually create a new tag |
caesarxuchao
added a commit
that referenced
this pull request
Oct 26, 2022
caesarxuchao
added a commit
that referenced
this pull request
Oct 26, 2022
Fix #709, which was backport hashicorp#27390, but missed a line of deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS introduced a breaking change on their task definition API. Fixed in a PR on the upstream repo, but obviously we need to backport here. hashicorp#27390
Context https://figma.slack.com/archives/C028C7B8XUP/p1666619400244529