Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CocoaPods + .gitignore #6

Closed
wants to merge 3 commits into from

Conversation

msmollin
Copy link

The structure of the framework was not conducive to allowing use
in CocoaPods. This commit restructures the file layout, adds appropriate
imports to necessary files, and creates a modular Podspec to allow
for integration of only individual components as needed by developers.

In addition, it removes unnecessary customizations of SVProgressHUD,
and includes SVProgressHUD as a dependency to avoid namespace collision
in projects that already include SVProgressHUD.

This places the onus on the developer to either utilize CocoaPods,
or manually include SVProgressHUD to satisfy all dependencies.
As such, this has been noted in the README.

Also I added a .gitignore, because .DS_Store makes commits sad.

Also, you'll need to add a tag for '0.0.1' before letting this loose.

@msmollin msmollin mentioned this pull request May 30, 2014
The structure of the framework was not conducive to allowing use
in CocoaPods. This commit restructures the file layout, adds appropriate
imports to necessary files, and creates a modular Podspec to allow
for integration of only individual components as needed by developers.

In addition, it removes unnecessary customizations of SVProgressHUD,
and includes SVProgressHUD as a dependency to avoid namespace collision
in projects that already include SVProgressHUD.

This places the onus on the developer to either utilize CocoaPods,
or manually include SVProgressHUD to satisfy all dependencies.
As such, this has been noted in the README.
@msmollin
Copy link
Author

msmollin commented Jun 2, 2014

One other thing is the PNGs used in FFCalendar are being copied in directly using the Util subspec ss.resource line, which is recommended against by the CocoaPods developers, as the pngs get copied directly into the app bundle and won't go through optimization.

The recommended way is to use a resource bundle, but I didn't want to refactor the code more than I already did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants